[14.0][FIX] account_statement_import_txt_xlsx: empty balance_column field #703
Conversation
|
Hi @alexey-pelykh, |
Tiago370
force-pushed
the
fix/empty_balance_column_field
branch
2 times, most recently
from
518f194 to
44db952
Compare
|
Backport of #693 |
| @@ -61,7 +62,9 @@ def parse(self, data_file, mapping, filename): | |||
| lines = self._parse_lines(mapping, data_file, currency_code) | |||
| if not lines: | |||
| return currency_code, account_number, [{"transactions": []}] | |||
|
|
|||
| if not isinstance(lines[0]["timestamp"], datetime): | |||
There was a problem hiding this comment.
How this is related to empty balance column?
There was a problem hiding this comment.
Hello @alexey-pelykh , this line was necessary, because some banks' statements put the first line without a date, containing only the description and the previous balance, so the solution I found was to copy the date of the next line. But I'm open to suggestions, thanks for the review.
There was a problem hiding this comment.
This should be done as a separate PR. Backport is a backport, sneaky changes aren't good :)
There was a problem hiding this comment.
I understand. I will provide a new PR and fix this one.
Tiago370
force-pushed
the
fix/empty_balance_column_field
branch
from
44db952 to
50fbb8e
Compare
|
This is replacing the attribution of @mileo . Why aren't you doing a cherry-pick? |
|
Good morning @pedrobaeza , thanks for the review. I did this because the module name is different in version 16.0. Is there any way I can do a cherry-pick in this situation? I am available for suggestions. |
|
Well, you can cherry-pick and when giving the error, then manually insert the changes and remove the offending files, and do |
|
@pedrobaeza Perfect, I'll try that. |
Tiago370
force-pushed
the
fix/empty_balance_column_field
branch
from
50fbb8e to
3460bcc
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This change addresses the error obtained when the column cell
amount_columnis empty.